From c45842f0bbf90875c5bafa2ced2a40e5ac2750e5 Mon Sep 17 00:00:00 2001 From: DIY Smart Code Date: Wed, 17 Sep 2025 12:44:25 +0200 Subject: [PATCH] feat: decouple task priority from task order (#652) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * feat: decouple task priority from task order This implements a dedicated priority system that operates independently from the existing task_order system, allowing users to set task priority without affecting visual drag-and-drop positioning. ## Changes Made ### Database - Add priority column to archon_tasks table with enum type (critical, high, medium, low) - Create database migration with safe enum handling and data backfill - Add proper indexing for performance ### Backend - Update UpdateTaskRequest to include priority field - Add priority validation in TaskService with enum checking - Include priority field in task list responses and ETag generation - Fix cache invalidation for priority updates ### Frontend - Update TaskPriority type from "urgent" to "critical" for consistency - Add changePriority method to useTaskActions hook - Update TaskCard to use direct priority field instead of task_order conversion - Update TaskEditModal priority form to use direct priority values - Fix TaskPriorityComponent to use correct priority enum values - Update buildTaskUpdates to include priority field changes - Add priority field to Task interface as required field - Update test fixtures to include priority field ## Key Features - ✅ Users can change task priority without affecting drag-and-drop order - ✅ Users can drag tasks to reorder without changing priority level - ✅ Priority persists correctly in database with dedicated column - ✅ All existing priority functionality continues working identically - ✅ Cache invalidation works properly for priority changes - ✅ Both TaskCard priority button and TaskEditModal priority work 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude * feat: add priority column to complete_setup.sql for fresh installations - Add task_priority enum type (low, medium, high, critical) - Add priority column to archon_tasks table with default 'medium' - Add index for priority column performance - Add documentation comment for priority field This ensures fresh installations include the priority system without needing to run the separate migration. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude * fix: include priority field in task creation payload When creating new tasks via TaskEditModal, the buildCreateRequest function was not including the priority field, causing new tasks to fall back to the database default ('medium') instead of respecting the user's selected priority in the modal. Added priority: localTask.priority || 'medium' to ensure the user's chosen priority is sent to the API during task creation. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude * feat: make priority migration safe and idempotent Replaced destructive DROP TYPE CASCADE with safe migration patterns: - Use DO blocks with EXCEPTION handling for enum and column creation - Prevent conflicts with complete_setup.sql for fresh installations - Enhanced backfill logic to preserve user-modified priorities - Only update tasks that haven't been modified (updated_at = created_at) - Add comprehensive error handling with informative notices - Migration can now be run multiple times safely This ensures the migration works for both existing installations (incremental migration) and fresh installations (complete_setup.sql) without data loss or conflicts. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude * feat: enforce NOT NULL constraint on priority column Data integrity improvements: Migration (add_priority_column_to_tasks.sql): - Add column as nullable first with DEFAULT 'medium' - Update any NULL values to 'medium' - Set NOT NULL constraint to enforce application invariants - Safe handling for existing columns with proper constraint checking Complete Setup (complete_setup.sql): - Priority column now DEFAULT 'medium' NOT NULL for fresh installations - Ensures consistency between migration and fresh install paths Both paths now enforce priority field as required, matching the frontend Task interface where priority is a required field. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude * feat: add priority support to task creation API Complete priority support for task creation: API Routes (projects_api.py): - Add priority field to CreateTaskRequest Pydantic model - Pass request.priority to TaskService.create_task call Task Service (task_service.py): - Add priority parameter to create_task method signature - Add priority validation using existing validate_priority method - Include priority field in database INSERT task_data - Include priority field in API response task object This ensures that new tasks created via TaskEditModal respect the user's selected priority instead of falling back to database default. Validation ensures only valid priority values (low, medium, high, critical) are accepted and stored in the database. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude * feat: implement clean slate priority migration (no backward compatibility) Remove all task_order to priority mapping logic for true decoupling: - All existing tasks get 'medium' priority (clean slate) - No complex CASE logic or task_order relationships - Users explicitly set priorities as needed after migration - Truly independent priority and visual ordering systems - Simpler, safer migration with no coupling logic This approach prioritizes clean architecture over preserving implied user intentions from the old coupled system. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude * refactor: rename TaskPriority.tsx to TaskPriorityComponent.tsx for consistency - Renamed file to match the exported component name - Updated import in index.ts barrel export - Maintains consistency with other component naming patterns --------- Co-authored-by: Claude Co-authored-by: Rasmus Widing --- .../projects/tasks/components/TaskCard.tsx | 32 +++--- .../tasks/components/TaskEditModal.tsx | 9 +- ...Priority.tsx => TaskPriorityComponent.tsx} | 15 ++- .../projects/tasks/components/index.ts | 2 +- .../tasks/hooks/tests/useTaskQueries.test.ts | 3 + .../projects/tasks/hooks/useTaskActions.ts | 14 ++- .../projects/tasks/hooks/useTaskEditor.ts | 2 + .../projects/tasks/services/taskService.ts | 5 +- .../features/projects/tasks/types/hooks.ts | 3 +- .../features/projects/tasks/types/priority.ts | 31 +++-- .../src/features/projects/tasks/types/task.ts | 4 +- migration/add_priority_column_to_tasks.sql | 107 ++++++++++++++++++ migration/complete_setup.sql | 10 ++ python/src/server/api_routes/projects_api.py | 6 + .../server/services/projects/task_service.py | 27 ++++- 15 files changed, 219 insertions(+), 51 deletions(-) rename archon-ui-main/src/features/projects/tasks/components/{TaskPriority.tsx => TaskPriorityComponent.tsx} (93%) create mode 100644 migration/add_priority_column_to_tasks.sql diff --git a/archon-ui-main/src/features/projects/tasks/components/TaskCard.tsx b/archon-ui-main/src/features/projects/tasks/components/TaskCard.tsx index 48aa87f..b116636 100644 --- a/archon-ui-main/src/features/projects/tasks/components/TaskCard.tsx +++ b/archon-ui-main/src/features/projects/tasks/components/TaskCard.tsx @@ -1,13 +1,13 @@ import { Tag } from "lucide-react"; import type React from "react"; -import { useCallback, useState } from "react"; +import { useCallback } from "react"; import { useDrag, useDrop } from "react-dnd"; import { useTaskActions } from "../hooks"; -import type { Assignee, Task } from "../types"; +import type { Assignee, Task, TaskPriority } from "../types"; import { getOrderColor, getOrderGlow, ItemTypes } from "../utils/task-styles"; import { TaskAssignee } from "./TaskAssignee"; import { TaskCardActions } from "./TaskCardActions"; -import { type Priority, TaskPriority } from "./TaskPriority"; +import { TaskPriorityComponent } from "."; export interface TaskCardProps { task: Task; @@ -34,12 +34,8 @@ export const TaskCard: React.FC = ({ selectedTasks, onTaskSelect, }) => { - // Local state for frontend-only priority - // NOTE: Priority is display-only and doesn't sync with backend yet - const [localPriority, setLocalPriority] = useState("medium"); - - // Use business logic hook - const { changeAssignee, isUpdating } = useTaskActions(projectId); + // Use business logic hook with changePriority + const { changeAssignee, changePriority, isUpdating } = useTaskActions(projectId); // Handlers - now just call hook methods const handleEdit = useCallback(() => { @@ -59,10 +55,12 @@ export const TaskCard: React.FC = ({ } }, [onDelete, task]); - const handlePriorityChange = useCallback((priority: Priority) => { - // Frontend-only priority change - setLocalPriority(priority); - }, []); + const handlePriorityChange = useCallback( + (priority: TaskPriority) => { + changePriority(task.id, priority); + }, + [changePriority, task.id], + ); const handleAssigneeChange = useCallback( (newAssignee: Assignee) => { @@ -218,8 +216,12 @@ export const TaskCard: React.FC = ({
- {/* Priority display (frontend-only for now) */} - + {/* Priority display connected to database */} +
diff --git a/archon-ui-main/src/features/projects/tasks/components/TaskEditModal.tsx b/archon-ui-main/src/features/projects/tasks/components/TaskEditModal.tsx index 7b40b51..2f839fe 100644 --- a/archon-ui-main/src/features/projects/tasks/components/TaskEditModal.tsx +++ b/archon-ui-main/src/features/projects/tasks/components/TaskEditModal.tsx @@ -18,9 +18,8 @@ import { TextArea, } from "../../../ui/primitives"; import { useTaskEditor } from "../hooks"; -import type { Assignee, Task } from "../types"; +import type { Assignee, Task, TaskPriority } from "../types"; import { FeatureSelect } from "./FeatureSelect"; -import type { Priority } from "./TaskPriority"; interface TaskEditModalProps { isModalOpen: boolean; @@ -52,7 +51,7 @@ export const TaskEditModal = memo( status: "todo", assignee: "User" as Assignee, feature: "", - priority: "medium" as Priority, // Frontend-only priority + priority: "medium" as TaskPriority, // Direct priority field }); } }, [editingTask]); @@ -133,9 +132,9 @@ export const TaskEditModal = memo( onPriorityChange(value as Priority)}> +