* feat: MCP server optimization with tool consolidation and vertical slice architecture - Consolidated MCP tools from ~20 to 8 tools for improved UX - Restructured to vertical slice architecture (features/domain pattern) - Optimized payload sizes with truncation and array count replacements - Changed default include_closed to true for better task visibility - Moved RAG module to features directory structure - Removed legacy modules directory in favor of feature-based organization Key improvements: - list_tasks, manage_task (create/update/delete consolidated) - list_projects, manage_project (create/update/delete consolidated) - list_documents, manage_document (create/update/delete consolidated) - list_versions, manage_version (create/restore consolidated) - Reduced default page size from 50 to 10 items - Added search query support to list operations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * feat: Consolidate MCP tools and rename list_* to find_* Major refactoring of MCP tools to reduce complexity and improve naming: ## Tool Consolidation (22 → ~10 tools) - Consolidated CRUD operations into two tools per domain: - find_[resource]: Handles list, search, and get single item - manage_[resource]: Handles create, update, delete with "action" parameter - Removed backward compatibility/legacy function mappings - Optimized response payloads with truncation (1000 char limit for projects/tasks) ## Renamed Functions - list_projects → find_projects - list_tasks → find_tasks - list_documents → find_documents - list_versions → find_versions ## Bug Fixes - Fixed supabase query chaining bug where .or_() calls overwrote previous conditions - Fixed search implementation to handle single vs multiple terms correctly ## Test Updates - Updated all tests to use new consolidated tools - Removed problematic test_consolidated_tools.py - Fixed error type assertions to match actual responses - All 44 tests passing ## Documentation Updates - Updated CLAUDE.md with new tool names and patterns - Updated MCP instructions with consolidated tool examples - Added guidance to avoid backward compatibility code ## API Changes - Updated API route defaults: include_closed=True, per_page=10 - Aligned defaults with consolidated tool implementations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
173 lines
5.7 KiB
Python
173 lines
5.7 KiB
Python
"""Unit tests for version management tools."""
|
|
|
|
import json
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
from mcp.server.fastmcp import Context
|
|
|
|
from src.mcp_server.features.documents.version_tools import register_version_tools
|
|
|
|
|
|
@pytest.fixture
|
|
def mock_mcp():
|
|
"""Create a mock MCP server for testing."""
|
|
mock = MagicMock()
|
|
# Store registered tools
|
|
mock._tools = {}
|
|
|
|
def tool_decorator():
|
|
def decorator(func):
|
|
mock._tools[func.__name__] = func
|
|
return func
|
|
|
|
return decorator
|
|
|
|
mock.tool = tool_decorator
|
|
return mock
|
|
|
|
|
|
@pytest.fixture
|
|
def mock_context():
|
|
"""Create a mock context for testing."""
|
|
return MagicMock(spec=Context)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_version_success(mock_mcp, mock_context):
|
|
"""Test successful version creation."""
|
|
register_version_tools(mock_mcp)
|
|
|
|
# Get the manage_version function
|
|
manage_version = mock_mcp._tools.get("manage_version")
|
|
|
|
assert manage_version is not None, "manage_version tool not registered"
|
|
|
|
# Mock HTTP response
|
|
mock_response = MagicMock()
|
|
mock_response.status_code = 200
|
|
mock_response.json.return_value = {
|
|
"version": {"version_number": 3, "field_name": "docs"},
|
|
"message": "Version created successfully",
|
|
}
|
|
|
|
with patch("src.mcp_server.features.documents.version_tools.httpx.AsyncClient") as mock_client:
|
|
mock_async_client = AsyncMock()
|
|
mock_async_client.post.return_value = mock_response
|
|
mock_client.return_value.__aenter__.return_value = mock_async_client
|
|
|
|
result = await manage_version(
|
|
mock_context,
|
|
action="create",
|
|
project_id="project-123",
|
|
field_name="docs",
|
|
content=[{"id": "doc-1", "title": "Test Doc"}],
|
|
change_summary="Added test document",
|
|
)
|
|
|
|
result_data = json.loads(result)
|
|
assert result_data["success"] is True
|
|
assert result_data["version"]["version_number"] == 3
|
|
assert "Version created successfully" in result_data["message"]
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_version_invalid_field(mock_mcp, mock_context):
|
|
"""Test version creation with invalid field name."""
|
|
register_version_tools(mock_mcp)
|
|
|
|
manage_version = mock_mcp._tools.get("manage_version")
|
|
|
|
# Mock 400 response for invalid field
|
|
mock_response = MagicMock()
|
|
mock_response.status_code = 400
|
|
mock_response.text = "invalid field_name"
|
|
|
|
with patch("src.mcp_server.features.documents.version_tools.httpx.AsyncClient") as mock_client:
|
|
mock_async_client = AsyncMock()
|
|
mock_async_client.post.return_value = mock_response
|
|
mock_client.return_value.__aenter__.return_value = mock_async_client
|
|
|
|
result = await manage_version(
|
|
mock_context, action="create", project_id="project-123", field_name="invalid", content={"test": "data"}
|
|
)
|
|
|
|
result_data = json.loads(result)
|
|
assert result_data["success"] is False
|
|
# Error must be structured format (dict), not string
|
|
assert "error" in result_data
|
|
assert isinstance(result_data["error"], dict), (
|
|
"Error should be structured format, not string"
|
|
)
|
|
assert result_data["error"]["type"] == "http_error"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_restore_version_success(mock_mcp, mock_context):
|
|
"""Test successful version restoration."""
|
|
register_version_tools(mock_mcp)
|
|
|
|
# Get the manage_version function
|
|
manage_version = mock_mcp._tools.get("manage_version")
|
|
|
|
assert manage_version is not None, "manage_version tool not registered"
|
|
|
|
# Mock HTTP response
|
|
mock_response = MagicMock()
|
|
mock_response.status_code = 200
|
|
mock_response.json.return_value = {"message": "Version 2 restored successfully"}
|
|
|
|
with patch("src.mcp_server.features.documents.version_tools.httpx.AsyncClient") as mock_client:
|
|
mock_async_client = AsyncMock()
|
|
mock_async_client.post.return_value = mock_response
|
|
mock_client.return_value.__aenter__.return_value = mock_async_client
|
|
|
|
result = await manage_version(
|
|
mock_context,
|
|
action="restore",
|
|
project_id="project-123",
|
|
field_name="docs",
|
|
version_number=2,
|
|
)
|
|
|
|
result_data = json.loads(result)
|
|
assert result_data["success"] is True
|
|
assert "restored successfully" in result_data["message"]
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_find_versions_with_filter(mock_mcp, mock_context):
|
|
"""Test listing versions with field name filter."""
|
|
register_version_tools(mock_mcp)
|
|
|
|
# Get the find_versions function
|
|
find_versions = mock_mcp._tools.get("find_versions")
|
|
|
|
assert find_versions is not None, "find_versions tool not registered"
|
|
|
|
# Mock HTTP response
|
|
mock_response = MagicMock()
|
|
mock_response.status_code = 200
|
|
mock_response.json.return_value = {
|
|
"versions": [
|
|
{"version_number": 1, "field_name": "docs", "change_summary": "Initial"},
|
|
{"version_number": 2, "field_name": "docs", "change_summary": "Updated"},
|
|
]
|
|
}
|
|
|
|
with patch("src.mcp_server.features.documents.version_tools.httpx.AsyncClient") as mock_client:
|
|
mock_async_client = AsyncMock()
|
|
mock_async_client.get.return_value = mock_response
|
|
mock_client.return_value.__aenter__.return_value = mock_async_client
|
|
|
|
result = await find_versions(mock_context, project_id="project-123", field_name="docs")
|
|
|
|
result_data = json.loads(result)
|
|
assert result_data["success"] is True
|
|
assert result_data["count"] == 2
|
|
assert len(result_data["versions"]) == 2
|
|
|
|
# Verify filter was passed
|
|
call_args = mock_async_client.get.call_args
|
|
assert call_args[1]["params"]["field_name"] == "docs"
|