Based on latest PR #306 review feedback: Fixed Issues: - Replaced last remaining basic error handling with MCPErrorFormatter in version_tools.py get_version function - Added proper error handling for invalid env vars in get_max_polling_attempts - Improved type hints with TaskUpdateFields TypedDict for better validation - All tools now consistently use get_default_timeout() (verified with grep) Test Improvements: - Added comprehensive tests for MCPErrorFormatter utility (10 tests) - Added tests for timeout_config utility (13 tests) - All 43 MCP tests passing with new utilities - Tests verify structured error format and timeout configuration Type Safety: - Created TaskUpdateFields TypedDict to specify exact allowed fields - Documents valid statuses and assignees in type comments - Improves IDE support and catches type errors at development time This completes all priority actions from the review: ✅ Fixed inconsistent timeout usage (was already done) ✅ Fixed error handling inconsistency ✅ Improved type hints for update_fields ✅ Added tests for utility modules |
||
|---|---|---|
| .. | ||
| features | ||
| utils | ||
| __init__.py | ||